diff --git a/ruoyi-admin/src/main/java/com/ruoyi/job/controller/MydoJobController.java b/ruoyi-admin/src/main/java/com/ruoyi/job/controller/MydoJobController.java index 13a2cbf..660505f 100644 --- a/ruoyi-admin/src/main/java/com/ruoyi/job/controller/MydoJobController.java +++ b/ruoyi-admin/src/main/java/com/ruoyi/job/controller/MydoJobController.java @@ -112,12 +112,12 @@ public class MydoJobController extends BaseController return toAjax(mydoJobService.deleteMydoJobByJobIds(jobIds)); } - @PreAuthorize("@ss.hasAnyPermi('job:mydoJob:OuthandFinish')") + @PreAuthorize("@ss.hasAnyPermi('job:mydoJob:outhandFinish')") @Log(title = "出库手动完成", businessType = BusinessType.OTHER) - @RequestMapping("/OuthandFinish") + @RequestMapping("/outhandFinish") public AjaxResult manualCompleted(@RequestParam("jobIds")String[] jobIds) { - return mydoJobService.OuthandFinish(jobIds); + return mydoJobService.outhandFinish(jobIds); } @PreAuthorize("@ss.hasAnyPermi('job:mydoJob:resendTaskToEntrance')") diff --git a/ruoyi-admin/src/main/java/com/ruoyi/job/service/IMydoJobService.java b/ruoyi-admin/src/main/java/com/ruoyi/job/service/IMydoJobService.java index cf02874..eaea0e5 100644 --- a/ruoyi-admin/src/main/java/com/ruoyi/job/service/IMydoJobService.java +++ b/ruoyi-admin/src/main/java/com/ruoyi/job/service/IMydoJobService.java @@ -1,13 +1,9 @@ package com.ruoyi.job.service; -import java.util.HashMap; import java.util.List; -import com.baomidou.mybatisplus.core.mapper.BaseMapper; -import com.baomidou.mybatisplus.extension.service.IService; import com.ruoyi.common.core.domain.AjaxResult; import com.ruoyi.job.domain.MydoJob; -import org.apache.ibatis.annotations.Param; /** * 作业信息Service接口 @@ -92,7 +88,7 @@ public interface IMydoJobService MydoJob selectMydoJobByEntranceList1(String entranceId); - AjaxResult OuthandFinish(String[] jobIds); + AjaxResult outhandFinish(String[] jobIds); AjaxResult ManuelTaskFinish(String taskNo); diff --git a/ruoyi-admin/src/main/java/com/ruoyi/job/service/impl/MydoJobServiceImpl.java b/ruoyi-admin/src/main/java/com/ruoyi/job/service/impl/MydoJobServiceImpl.java index 04268cb..06df88c 100644 --- a/ruoyi-admin/src/main/java/com/ruoyi/job/service/impl/MydoJobServiceImpl.java +++ b/ruoyi-admin/src/main/java/com/ruoyi/job/service/impl/MydoJobServiceImpl.java @@ -102,11 +102,15 @@ public class MydoJobServiceImpl implements IMydoJobService mydoJobMapper.insertHistory(jobId); //当执行任务的【删除】操作时(特殊场景需要手动处理异常导致不需要入库时,此时不需要向回传异常) // 此处顺便处理对应任务号生成的堆垛机执行队列,省去sql直接表中删记录的操作 - String taskNo = selectMydoJobByJobId(jobId).getTaskNo(); - if (ddjDeviceExecutionQueueService.selectDdjDeviceExecutionQueueByTaskNo(taskNo) != null) { - ddjDeviceExecutionQueueService.deleteDdjDeviceExecutionQueueByTaskNo(taskNo); + if (selectMydoJobByJobId(jobId) != null){ + String taskNo = selectMydoJobByJobId(jobId).getTaskNo(); + if (ddjDeviceExecutionQueueService.selectDdjDeviceExecutionQueueByTaskNo(taskNo) != null) { + ddjDeviceExecutionQueueService.deleteDdjDeviceExecutionQueueByTaskNo(taskNo); + } } + + } return mydoJobMapper.deleteMydoJobByJobIds(jobIds); } @@ -207,12 +211,11 @@ public class MydoJobServiceImpl implements IMydoJobService /** * 手动完成同一【作业单号】的作业 - * 如果【jobid】和【taskno】是一对多的情况,使用上一个方法手动完成作业会导致整个【jobid】单据完成回传 * @param jobIds * @return */ @Override - public AjaxResult OuthandFinish(String[] jobIds) { + public AjaxResult outhandFinish(String[] jobIds) { //获取所有符合【任务单号】的作业 for (String jobId : jobIds) { diff --git a/ruoyi-common/src/main/java/com/ruoyi/common/core/controller/BaseController.java b/ruoyi-common/src/main/java/com/ruoyi/common/core/controller/BaseController.java index a685e06..9ef12d5 100644 --- a/ruoyi-common/src/main/java/com/ruoyi/common/core/controller/BaseController.java +++ b/ruoyi-common/src/main/java/com/ruoyi/common/core/controller/BaseController.java @@ -146,7 +146,7 @@ public class BaseController */ protected AjaxResult toAjax(int rows) { - return rows > 0 ? AjaxResult.success() : AjaxResult.error(); + return rows != 0 ? AjaxResult.success() : AjaxResult.error(); } /** diff --git a/ruoyi-ui/src/api/job/mydoJob.js b/ruoyi-ui/src/api/job/mydoJob.js index 3f738c4..49e8d5f 100644 --- a/ruoyi-ui/src/api/job/mydoJob.js +++ b/ruoyi-ui/src/api/job/mydoJob.js @@ -55,7 +55,7 @@ export function delMydoJob(jobId) { // 手动完成作业 export function handFinish(jobIds) { return request({ - url: '/job/mydoJob/OuthandFinish', + url: '/job/mydoJob/outhandFinish', method: 'get', params: { jobIds: jobIds } }) diff --git a/ruoyi-ui/src/views/device/ddj/index.vue b/ruoyi-ui/src/views/device/ddj/index.vue index 3b5da05..266c80e 100644 --- a/ruoyi-ui/src/views/device/ddj/index.vue +++ b/ruoyi-ui/src/views/device/ddj/index.vue @@ -70,6 +70,11 @@ + + +